From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTP id 03A6D2B491 for ; Thu, 20 Sep 2018 11:58:20 -0400 (EDT) Received: from turing.freelists.org ([127.0.0.1]) by localhost (turing.freelists.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id Vo2Bq-rT8C70 for ; Thu, 20 Sep 2018 11:58:19 -0400 (EDT) Received: from smtp60.i.mail.ru (smtp60.i.mail.ru [217.69.128.40]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTPS id 4B1B02B48B for ; Thu, 20 Sep 2018 11:58:19 -0400 (EDT) Date: Thu, 20 Sep 2018 18:58:16 +0300 From: Kirill Yukhin Subject: [tarantool-patches] Re: [PATCH v1 1/1] sql: decrease SELECT_COMPOUND_LIMIT threshold Message-ID: <20180920155816.hxbjevxjhio43fnr@tarantool.org> References: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: Sender: tarantool-patches-bounce@freelists.org Errors-to: tarantool-patches-bounce@freelists.org Reply-To: tarantool-patches@freelists.org List-help: List-unsubscribe: List-software: Ecartis version 1.0.0 List-Id: tarantool-patches List-subscribe: List-owner: List-post: List-archive: To: tarantool-patches@freelists.org Cc: korablev@tarantool.org, Kirill Shcherbatov Hello, On 11 сен 14:47, Kirill Shcherbatov wrote: > Decreased the maximum number of terms in a compound SELECT > statement. The code generator for compound SELECT statements > does one level of recursion for each term. A stack overflow can > result if the number of terms is too large. In practice, most > SQL never has more than 3 or 4 terms. > Fiber stack is 64KB by default, so maximum number of entities > should be about 30 to stack guard will not be triggered. > > Closes #3382. > --- > Branch: http://github.com/tarantool/tarantool/tree/kshsh/gh-3382-select-compound-limit-fix > Issue: https://github.com/tarantool/tarantool/issues/3382 I've checked your patch into 2.0 branch. BTW, I've submitted feature request to relax the restriction: https://github.com/tarantool/tarantool/issues/3700 -- Regards, Kirill Yukhin