From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTP id 9A7C22B21C for ; Thu, 20 Sep 2018 11:42:55 -0400 (EDT) Received: from turing.freelists.org ([127.0.0.1]) by localhost (turing.freelists.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id zhpuv8mW4CuP for ; Thu, 20 Sep 2018 11:42:55 -0400 (EDT) Received: from smtp38.i.mail.ru (smtp38.i.mail.ru [94.100.177.98]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTPS id 57B5026E80 for ; Thu, 20 Sep 2018 11:42:55 -0400 (EDT) Date: Thu, 20 Sep 2018 18:42:47 +0300 From: Kirill Yukhin Subject: [tarantool-patches] Re: [PATCH] Fix Debug build on GCC 8 Message-ID: <20180920154247.vqm6m3a5bwofyeyx@tarantool.org> References: <8c538963a78f22746233b22648fb2aa6933dc135.1536991382.git.alexander.turenko@tarantool.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <8c538963a78f22746233b22648fb2aa6933dc135.1536991382.git.alexander.turenko@tarantool.org> Sender: tarantool-patches-bounce@freelists.org Errors-to: tarantool-patches-bounce@freelists.org Reply-To: tarantool-patches@freelists.org List-help: List-unsubscribe: List-software: Ecartis version 1.0.0 List-Id: tarantool-patches List-subscribe: List-owner: List-post: List-archive: To: Alexander Turenko Cc: tarantool-patches@freelists.org, Konstantin Osipov Hello, On 15 сен 09:07, Alexander Turenko wrote: > Fixed false positive -Wimplicit-fallthrough in http_parser.c by adding a > break. The code jumps anyway, so the execution flow is not changed. > > Fixed false positive -Wparenthesis in reflection.h by removing the > parentheses. The argument 'method' of the macro 'type_foreach_method' is > just name of the loop variable and is passed to the macro for > readability reasons. > > Fixed false positive -Wcast-function-type triggered by reflection.h by > adding -Wno-cast-function-type for sources and unit tests. We cast a > pointer to a member function to an another pointer to member function to > store it in a structure, but we cast it back before made a call. It is > legal and does not lead to an undefined behaviour. > > Fixes #3685. > --- > > issue: https://github.com/tarantool/tarantool/issues/3685 > branch: https://github.com/tarantool/tarantool/tree/Totktonada/gh-3685-fix-debug-build-gcc-8 > travis-ci: https://travis-ci.org/tarantool/tarantool/builds/428903995 I've checked the patch into 1.9 branch. -- Regards, Kirill Yukhin