From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTP id 5D06227681 for ; Wed, 19 Sep 2018 12:57:53 -0400 (EDT) Received: from turing.freelists.org ([127.0.0.1]) by localhost (turing.freelists.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id Ll8kC-lMYm9B for ; Wed, 19 Sep 2018 12:57:53 -0400 (EDT) Received: from smtp44.i.mail.ru (smtp44.i.mail.ru [94.100.177.104]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTPS id 1B4B020FF6 for ; Wed, 19 Sep 2018 12:57:51 -0400 (EDT) Date: Wed, 19 Sep 2018 19:57:50 +0300 From: Alexander Turenko Subject: [tarantool-patches] Re: [PATCH v2] test: enable parallel mode for wall_off tests Message-ID: <20180919165750.ew3lv22q3gbtxdew@tkn_work_nb> References: <20180917133145.vzyvounwxvuclujz@tkn_work_nb> <20180918161025.21769-1-sergw@tarantool.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20180918161025.21769-1-sergw@tarantool.org> Sender: tarantool-patches-bounce@freelists.org Errors-to: tarantool-patches-bounce@freelists.org Reply-To: tarantool-patches@freelists.org List-help: List-unsubscribe: List-software: Ecartis version 1.0.0 List-Id: tarantool-patches List-subscribe: List-owner: List-post: List-archive: To: Sergei Voronezhskii Cc: tarantool-patches@freelists.org Hi! Comments are below. WBR, Alexander Turenko. Maybe we should place the fix on top of 1.9. I asked Kostya O. and Kirill Yu. about that in the chat, please ping them and proceed appropriately. > enable parallel mode for wall_off tests wall -> wal > diff --git a/test/wal_off/lua.test.lua b/test/wal_off/lua.test.lua > index 7daf9f3f6..02ec9e795 100644 > --- a/test/wal_off/lua.test.lua > +++ b/test/wal_off/lua.test.lua > @@ -1,5 +1,6 @@ > env = require('test_run') > test_run = env.new() > +test_run:cmd("restart server default with cleanup=1") So the approach is to restart the server with clean up for each tests. It will slows down the execution. The another way you propose (w/ spaces renaming) seems to be better for me. Anyway, you don't describe a reason why exactly this is needed. How we can meet an inconsistent state if a server was not restarted or restarted with clean up? I propose to describe problems you fix in the commit message, otherwise I'll need to investigate the issue again after you to understand it and give the review.