From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Date: Wed, 19 Sep 2018 04:48:57 +0300 From: Konstantin Osipov Subject: Re: [PATCH v2 4/8] vinyl: report pages and bytes_compressed in dump/compact in/out stats Message-ID: <20180919014857.GJ31150@chai> References: <89b4528c5e34733ef1162cd443905743a6522104.1537115208.git.vdavydov.dev@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <89b4528c5e34733ef1162cd443905743a6522104.1537115208.git.vdavydov.dev@gmail.com> To: Vladimir Davydov Cc: tarantool-patches@freelists.org List-ID: * Vladimir Davydov [18/09/17 15:05]: > There's no reason not to report pages and bytes_compressed under > disk.stat.dump.out and disk.stat.compact.{in,out} apart from using > the same struct for dump and compaction statistics (vy_compact_stat). > The statistics are going to differ anyway once compaction queue size > is added to disk.stat.compact so let's zap struct vy_compact_stat > and report as much info as we can. OK to push. -- Konstantin Osipov, Moscow, Russia, +7 903 626 22 32 http://tarantool.io - www.twitter.com/kostja_osipov