From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Date: Wed, 19 Sep 2018 04:43:31 +0300 From: Konstantin Osipov Subject: Re: [PATCH v2 1/8] vinyl: fix force compaction logic Message-ID: <20180919014331.GG31150@chai> References: <973667c6d065b0c91c0c7f9615c14d2e726fa360.1537115208.git.vdavydov.dev@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <973667c6d065b0c91c0c7f9615c14d2e726fa360.1537115208.git.vdavydov.dev@gmail.com> To: Vladimir Davydov Cc: tarantool-patches@freelists.org List-ID: * Vladimir Davydov [18/09/17 15:05]: > This patch addresses a few problems index.compact() is suffering from, > namely: > > - When a range is split or coalesced, it should inherit the value of > needs_compaction flag from the source ranges. Currently, the flag is > cleared so that the resulting range may be not compacted. > > - If a range has no slices, we shouldn't set needs_compaction flag for > it, because obviously it can't be compacted, but we do. > > - The needs_compaction flag should be cleared as soon as we schedule a > range for compaction, not when all slices have been compacted into > one, as we presently expect, because the latter may never happen > under a write-intensive load. OK to push (I assume you've already implemented the comment changes we discussed in the chat). -- Konstantin Osipov, Moscow, Russia, +7 903 626 22 32 http://tarantool.io - www.twitter.com/kostja_osipov