From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Date: Mon, 3 Sep 2018 11:10:14 +0300 From: Vladimir Davydov Subject: Re: [tarantool-patches] Re: [PATCH 2/7] vinyl: add global memory stats Message-ID: <20180903081014.ojfkitqajqkglo3u@esperanza> References: <1d418366ba3fd7fd5dfa651ab340ba931ec3577f.1535917763.git.vdavydov.dev@gmail.com> <20180902222717.GD536@chai> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20180902222717.GD536@chai> To: Konstantin Osipov Cc: tarantool-patches@freelists.org List-ID: On Mon, Sep 03, 2018 at 01:27:17AM +0300, Konstantin Osipov wrote: > * Vladimir Davydov [18/09/02 23:23]: > > box.info.memory() gives you some insight on what memory is used for, > > but it's very coarse. For vinyl we need finer grained global memory > > statistics. > > > > This patch adds such: they are reported under box.stat.vinyl().memory > > and consist of the following entries: > > > > - level0: sum size of level-0 of all LSM trees. > > - tx: size of memory used by tx write and read sets. > > - tuple_cache: size of memory occupied by tuple cache. > > - page_index: size of memory used for storing page indexes. > > - bloom_filter: size of memory used for storing bloom filters. > > > > It also removes box.stat.vinyl().cache, as the size of cache is now > > reported under memory.tuple_cache. > > Please add a plea to docbot. IMO it's pointless to write a docbot request in each patch, because other vinyl statistics (per index and global) aren't documented, either. I'll open a separate ticket manually once we are done with throttling.