From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTP id 73D6527FA5 for ; Sun, 2 Sep 2018 18:30:38 -0400 (EDT) Received: from turing.freelists.org ([127.0.0.1]) by localhost (turing.freelists.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id NQG5qcZu-vaT for ; Sun, 2 Sep 2018 18:30:38 -0400 (EDT) Received: from smtp36.i.mail.ru (smtp36.i.mail.ru [94.100.177.96]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTPS id 350C627F3D for ; Sun, 2 Sep 2018 18:30:38 -0400 (EDT) Received: by smtp36.i.mail.ru with esmtpa (envelope-from ) id 1fwatA-0007mb-E8 for tarantool-patches@freelists.org; Mon, 03 Sep 2018 01:30:36 +0300 Date: Mon, 3 Sep 2018 01:30:36 +0300 From: Konstantin Osipov Subject: [tarantool-patches] Re: [PATCH 3/7] vinyl: add global disk stats Message-ID: <20180902223036.GE536@chai> References: <6a406b8aaf61ee0ae51f66b30e1f81b927476a98.1535917763.git.vdavydov.dev@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <6a406b8aaf61ee0ae51f66b30e1f81b927476a98.1535917763.git.vdavydov.dev@gmail.com> Sender: tarantool-patches-bounce@freelists.org Errors-to: tarantool-patches-bounce@freelists.org Reply-To: tarantool-patches@freelists.org List-help: List-unsubscribe: List-software: Ecartis version 1.0.0 List-Id: tarantool-patches List-subscribe: List-owner: List-post: List-archive: To: tarantool-patches@freelists.org * Vladimir Davydov [18/09/02 23:23]: > This patch adds some essential disk statistics to box.stat.vinyl(). > The new statistics are reported under the 'disk' section and currently > include the following fields: > > - data_files: number of open data files (*.run). > - data_size: size of data stored on disk. > - index_size: size of index stored on disk. > - dump_total: number of bytes written by dump tasks. > - compact_total: number of bytes writted by compaction tasks. How about also maintaining statistics about the amount of garbage, i.e. runs removed from an LSM but maintained 'cause of checkpoint or backup? These stats would also be useful on per index basis. The patch itself is OK to push. -- Konstantin Osipov, Moscow, Russia, +7 903 626 22 32 http://tarantool.io - www.twitter.com/kostja_osipov