From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTP id 7E2FB2A355 for ; Thu, 30 Aug 2018 10:40:11 -0400 (EDT) Received: from turing.freelists.org ([127.0.0.1]) by localhost (turing.freelists.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id IedcuLk2F8Tl for ; Thu, 30 Aug 2018 10:40:11 -0400 (EDT) Received: from smtp63.i.mail.ru (smtp63.i.mail.ru [217.69.128.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTPS id 3E30E2A153 for ; Thu, 30 Aug 2018 10:40:10 -0400 (EDT) Date: Thu, 30 Aug 2018 17:40:03 +0300 From: Konstantin Osipov Subject: [tarantool-patches] Re: [PATCH 2/2] On ctl event trigger Message-ID: <20180830144003.GA3891@chai> References: <7d9ccb894ef2915181454db39ead93497f9ff9aa.1535472838.git.georgy@tarantool.org> <20180830123807.w2p4fiwcld2v3yun@esperanza> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20180830123807.w2p4fiwcld2v3yun@esperanza> Sender: tarantool-patches-bounce@freelists.org Errors-to: tarantool-patches-bounce@freelists.org Reply-To: tarantool-patches@freelists.org List-help: List-unsubscribe: List-software: Ecartis version 1.0.0 List-Id: tarantool-patches List-subscribe: List-owner: List-post: List-archive: To: tarantool-patches@freelists.org Cc: Georgy Kirichenko * Vladimir Davydov [18/08/30 15:39]: > Second, IMO the event trigger should be installed with box.ctl.on_event > (not box.ctl_event.on_ctl_event), and constants should be defined in > box.ctl.event (not box.ctl_event.const()). I agree with this name change. -- Konstantin Osipov, Moscow, Russia, +7 903 626 22 32 http://tarantool.io - www.twitter.com/kostja_osipov