From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <vdavydov.dev@gmail.com>
Date: Fri, 24 Aug 2018 17:07:59 +0300
From: Vladimir Davydov <vdavydov.dev@gmail.com>
Subject: Re: [PATCH 1/3] socket: evaluate buffer size in recv / recvfrom
Message-ID: <20180824140759.yj7f6aygc7nk6f5g@esperanza>
References: <cover.1535076888.git.alexander.turenko@tarantool.org>
 <36b23f07009f3cd467c1eb7e54e982b1f907908d.1535076888.git.alexander.turenko@tarantool.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <36b23f07009f3cd467c1eb7e54e982b1f907908d.1535076888.git.alexander.turenko@tarantool.org>
To: Alexander Turenko <alexander.turenko@tarantool.org>
Cc: tarantool-patches@freelists.org, Yaroslav Dynnikov <yaroslav.dynnikov@tarantool.org>
List-ID: <tarantool-patches.dev.tarantool.org>

On Fri, Aug 24, 2018 at 05:47:37AM +0300, Alexander Turenko wrote:
> diff --git a/src/lua/socket.lua b/src/lua/socket.lua
> index 06306eae2..946e11e9e 100644
> --- a/src/lua/socket.lua
> +++ b/src/lua/socket.lua
> @@ -1165,6 +1216,8 @@ socket_mt   = {
>          read = socket_read;
>          write = socket_write;
>          send = socket_send;
> +        is_udp = socket_is_udp;
> +        dgram_length = socket_dgram_length;

I don't think it's a good idea to add these two methods to the public
API. Nobody asked for this. Let's please remove them.

>          recv = socket_recv;
>          recvfrom = socket_recvfrom;
>          sendto = socket_sendto;