From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Date: Fri, 24 Aug 2018 00:10:57 +0300 From: Konstantin Osipov Subject: Re: [PATCH] vinyl: abort rw transactions before DDL Message-ID: <20180823211057.GB30863@chai> References: <20180803151700.shaatbqui63xbjt3@esperanza> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: To: Vladimir Davydov Cc: tarantool-patches@freelists.org List-ID: * Vladimir Davydov [18/08/03 18:23]: > When building a new index or checking a space format, we propagate > changes done to the space during the procedure with the aid of an > on_replace trigger. The problem is there may be transactions with a > non-empty write set when we install the trigger. Changes done by > those transactions will not be seen by the trigger and so they won't > make it to the new index, resulting in an inconsistency between the > primary and secondary indexes. To fix this issue, let's abort all > rw transactions after setting the trigger. Note, transactions that > reached WAL can't be aborted so we wait for them to complete. If I may nitpick: - we could have a list per lsm, not a global one in tx manager - abort only the transactions which are in the list of this lsm This would both exclude read transactions and reduce the amount of aborted transactions a great deal. -- Konstantin Osipov, Moscow, Russia, +7 903 626 22 32 http://tarantool.io - www.twitter.com/kostja_osipov