From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTP id DE2222A4D0 for ; Thu, 23 Aug 2018 17:03:11 -0400 (EDT) Received: from turing.freelists.org ([127.0.0.1]) by localhost (turing.freelists.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id zAfHH5DAUjT1 for ; Thu, 23 Aug 2018 17:03:11 -0400 (EDT) Received: from smtp61.i.mail.ru (smtp61.i.mail.ru [217.69.128.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTPS id 9D8922A4A6 for ; Thu, 23 Aug 2018 17:03:11 -0400 (EDT) Date: Fri, 24 Aug 2018 00:03:14 +0300 From: Alexander Turenko Subject: [tarantool-patches] Re: [PATCH v3] json: add options to json.encode() Message-ID: <20180823210313.rzj6lgcldayn52c2@tkn_work_nb> References: <2952461532611162@iva5-08e20335b0d9.qloud-c.yandex.net> <33ec689b-9aca-97e9-e56f-c0aee649ad87@tarantool.org> <28658371533050946@myt4-74a8acfc13eb.qloud-c.yandex.net> <898281533156060@myt5-cf6d29327892.qloud-c.yandex.net> <26831531533678724@myt5-f9d71769b752.qloud-c.yandex.net> <6304221534202083@iva8-37fc2ad204cd.qloud-c.yandex.net> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: Sender: tarantool-patches-bounce@freelists.org Errors-to: tarantool-patches-bounce@freelists.org Reply-To: tarantool-patches@freelists.org List-help: List-unsubscribe: List-software: Ecartis version 1.0.0 List-Id: tarantool-patches List-subscribe: List-owner: List-post: List-archive: To: Vladislav Shpilevoy Cc: "roman.habibov1@yandex.ru" , "tarantool-patches@freelists.org" Hi! I'll make the review on the next week. Sorry for the late response. WBR, Alexander Turenko. On Wed, Aug 15, 2018 at 01:29:38AM +0300, Vladislav Shpilevoy wrote: > Hi! Thanks for the fixes! I have force pushed one minor > fix for alignment in lua_cjson.c. > > Alexander, please, make a second review. >