From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Date: Tue, 21 Aug 2018 18:44:03 +0300 From: Konstantin Osipov Subject: Re: [PATCH v2 6/7] vinyl: zap vy_mem::min_lsn and rename max_lsn to dump_lsn Message-ID: <20180821154403.GF28159@chai> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: To: Vladimir Davydov Cc: tarantool-patches@freelists.org List-ID: * Vladimir Davydov [18/08/21 15:19]: > We never use vy_mem::min_lsn so let's zap it. As for max_lsn, we only > need it to update vy_lsm::dump_lsn (max LSN stored on disk). Let's > rename it appropriately. There's another reason to do that. Once we > start storing deferred DELETE statements in memory (see #2129), it won't > be the max statement LSN stored in vy_mem anymore, because we will > account WAL LSN of deferred DELETE statements there too. Renaming it to > dump_lsn will help avoid confusion. Such a simple change making things so much easier to track. Thanks. OK to push. -- Konstantin Osipov, Moscow, Russia, +7 903 626 22 32 http://tarantool.io - www.twitter.com/kostja_osipov