From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <kostja@tarantool.org>
Date: Tue, 21 Aug 2018 18:14:57 +0300
From: Konstantin Osipov <kostja@tarantool.org>
Subject: Re: [PATCH v2 2/7] vinyl: teach write iterator to return overwritten
 tuples
Message-ID: <20180821151457.GB28159@chai>
References: <cover.1534847663.git.vdavydov.dev@gmail.com>
 <e43cfefb0c13edbd2df9fb26c4198bd967e349c9.1534847663.git.vdavydov.dev@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <e43cfefb0c13edbd2df9fb26c4198bd967e349c9.1534847663.git.vdavydov.dev@gmail.com>
To: Vladimir Davydov <vdavydov.dev@gmail.com>
Cc: tarantool-patches@freelists.org
List-ID: <tarantool-patches.dev.tarantool.org>

* Vladimir Davydov <vdavydov.dev@gmail.com> [18/08/21 15:19]:
>  	/*
> +	 * Deferred DELETE statements can only be produced by
> +	 * primary index compaction.
> +	 */
> +	assert(is_primary || handler == NULL);
> +	/*

With this assert, do you really need this check:

> +static int
> +vy_write_iterator_deferred_delete(struct vy_write_iterator *stream,
> +				  struct tuple *stmt)
> +{
> +	if (!stream->is_primary)
> +		return 0;

?

Otherwise lgtm.

-- 
Konstantin Osipov, Moscow, Russia, +7 903 626 22 32
http://tarantool.io - www.twitter.com/kostja_osipov