From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Date: Tue, 21 Aug 2018 18:08:22 +0300 From: Konstantin Osipov Subject: Re: [PATCH v2 1/7] vinyl: do not store meta in secondary index runs Message-ID: <20180821150822.GA28159@chai> References: <98b102827b334d6a8664a7ea6f78d01d1880beef.1534847663.git.vdavydov.dev@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <98b102827b334d6a8664a7ea6f78d01d1880beef.1534847663.git.vdavydov.dev@gmail.com> To: Vladimir Davydov Cc: tarantool-patches@freelists.org List-ID: * Vladimir Davydov [18/08/21 15:19]: > Currenlty, tuple meta is only needed for storing statement flags in run > files. In the scope of #2129 two statement flags will be introduced, > VY_STMT_SKIP_READ and VY_STMT_DEFERRED_DELETE. None of them makes any > sense for secondary indexes. If we encode meta for secondary index > statements, we will have to either clear the flags on the upper level > (e.g. in the write iterator) or filter them out before encoding a > statement. Alternatively, we can skip encoding meta for secondary index > statements altogether, and this is what this patch does, because it's > the simplest and clearest method for now. If tuple meta is ever used for > storing anything else besides statement flags or a new statement flag > appears that may be used with secondary index statements, we will > recover the code and mask out those flags for secondary indexes. OK to push. -- Konstantin Osipov, Moscow, Russia, +7 903 626 22 32 http://tarantool.io - www.twitter.com/kostja_osipov