From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <vdavydov.dev@gmail.com>
Date: Tue, 21 Aug 2018 16:26:26 +0300
From: Vladimir Davydov <vdavydov.dev@gmail.com>
Subject: Re: [PATCH v2] tarantoolctl: return an error on enter to a dead
 socket.
Message-ID: <20180821132626.prljvymufahujzt6@esperanza>
References: <20180821065621.27693-1-sergepetrenko@tarantool.org>
 <20180821122835.6w3kyvlznpxjxhij@esperanza>
 <17F09AB8-AD92-46D6-BB41-6FF109C336CA@tarantool.org>
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <17F09AB8-AD92-46D6-BB41-6FF109C336CA@tarantool.org>
To: Serge Petrenko <sergepetrenko@tarantool.org>
Cc: kostja@tarantool.org, tarantool-patches@freelists.org
List-ID: <tarantool-patches.dev.tarantool.org>

On Tue, Aug 21, 2018 at 03:51:57PM +0300, Serge Petrenko wrote:
> >> +-- check enter
> >> +do
> >> +    local dir = fio.tempdir()
> >> +
> >> +    local code = [[ box.cfg{} ]]
> >> +    create_script(dir, 'script.lua', code)
> >> +
> >> +    local status, err = pcall(function()
> >> +        test:test("check error codes in case of enter", function(test_i)
> >> +            test_i:plan(10)
> >> +            check_ok(test_i, dir, 'enter', 'script', 1, nil, "Can't connect to")
> >> +            local console_sock = 'script.control'
> >> +            console_sock = fio.pathjoin(dir, console_sock)
> >> +            test_i:is(fio.path.exists(console_sock), false, "directory clean")
> >> +            check_ok(test_i, dir, 'start', 'script', 0)
> >> +            tctl_wait_start(dir, 'script')
> >> +            test_i:is(fio.path.exists(console_sock), true,
> >> +                      "unix socket created")
> >> +            check_ok(test_i, dir, 'stop', 'script', 0)
> >> +            wait_delete(console_sock)
> > 
> > There's tctl_wait_stop() for this.
> 
> Yes, fixed. New diff is below.
> 
> > 
> > Anyway, why do you need to start/stop instance before trying to enter
> > it? AFAIU you just want to check that 'tarantoolctl enter' returns an
> > error when called on a closed socket so the code below should be enough.
> 
> I wanted to stress that I’m using a correct path to socket. Not just creating some
> Random file at some random place and then expecting `tarantoolctl enter` to fail.
> Also test that there is no socket after `tarantoolctl stop` was a request by Kostja
> For previous patch, but it is irrelevant now. We can remove it, if you want, but
> I believe it’s some extra coverage, nothing wrong with that.

OK, pushed to 1.10.