From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Date: Mon, 20 Aug 2018 20:03:01 +0300 From: Vladimir Davydov Subject: Re: [tarantool-patches] [PATCH] tarantoolctl: update confusing error message Message-ID: <20180820170301.3o6khnzs5v5n2y5e@esperanza> References: <20180809141806.52803-1-k.belyavskiy@tarantool.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20180809141806.52803-1-k.belyavskiy@tarantool.org> To: tarantool-patches@freelists.org List-ID: On Thu, Aug 09, 2018 at 05:18:06PM +0300, Konstantin Belyavskiy wrote: > There were two complains regarding to tarantoolctl eval behaviour: > 1. confusing message - fixed. > 2. eval have correct return code there is no need in extra message > With built-in function 'error()' is used, we can have some > unexpected behaviour like: stat, err = pcall(error(1)) > To distinguish case with error(message) from something went bad > suggest to use pattern "[string ...]. Mons, who filed the issue, wanted us to remove this error message, not fix it or anything else. I did it by myself.