From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <kostja@tarantool.org>
Date: Mon, 20 Aug 2018 14:24:31 +0300
From: Konstantin Osipov <kostja@tarantool.org>
Subject: Re: [PATCH 11/18] vinyl: use snap_io_rate_limit for initial dump
 bandwidth estimate
Message-ID: <20180820112431.GN8716@chai>
References: <cover.1534432819.git.vdavydov.dev@gmail.com>
 <111debb195d9c9780edef15d311ea94282a4fd60.1534432819.git.vdavydov.dev@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <111debb195d9c9780edef15d311ea94282a4fd60.1534432819.git.vdavydov.dev@gmail.com>
To: Vladimir Davydov <vdavydov.dev@gmail.com>
Cc: tarantool-patches@freelists.org
List-ID: <tarantool-patches.dev.tarantool.org>

* Vladimir Davydov <vdavydov.dev@gmail.com> [18/08/16 23:03]:
> The user can limit dump bandwidth with box.cfg.snap_io_rate_limit to a
> value, which is less than the current estimate. To avoid stalls caused
> by overestimating dump bandwidth, we must take into account the limit
> for the initial guess and forget all observations whenever it changes.

>  void
> +vy_quota_reset_dump_bw(struct vy_quota *q, size_t max)
> +{
> +	histogram_reset(q->dump_bw_hist);
> +	q->dump_bw = MIN(VY_DEFAULT_DUMP_BANDWIDTH, max);
> +}
> +

This sounds like vy_quota_set_dump_bw to me, not reset().

Otherwise OK to push.

-- 
Konstantin Osipov, Moscow, Russia, +7 903 626 22 32
http://tarantool.io - www.twitter.com/kostja_osipov