From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Date: Mon, 20 Aug 2018 14:21:45 +0300 From: Konstantin Osipov Subject: Re: [PATCH 09/18] vinyl: cache dump bandwidth for timer invocation Message-ID: <20180820112145.GL8716@chai> References: <96f47fd882aa68aa315ce90d77e5c40ca471ffdf.1534432819.git.vdavydov.dev@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <96f47fd882aa68aa315ce90d77e5c40ca471ffdf.1534432819.git.vdavydov.dev@gmail.com> To: Vladimir Davydov Cc: tarantool-patches@freelists.org List-ID: * Vladimir Davydov [18/08/16 23:03]: > We don't need to compute a percentile of dump bandwidth histogram on > each invocation of quota timer callback, because it may only be updated > on dump completion. Let's cache it. Currently, it isn't that important, > because the timer period is set to 1 second. However, once we start > using the timer for throttling, we'll have to make it run more often and > so caching the dump bandwidth value will make sense. OK to push. -- Konstantin Osipov, Moscow, Russia, +7 903 626 22 32 http://tarantool.io - www.twitter.com/kostja_osipov