From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Date: Mon, 20 Aug 2018 14:15:17 +0300 From: Konstantin Osipov Subject: Re: [PATCH 07/18] vinyl: tune dump bandwidth histogram buckets Message-ID: <20180820111517.GJ8716@chai> References: <950c240800e03ac28cdbca904cb7679663ed36bc.1534432819.git.vdavydov.dev@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <950c240800e03ac28cdbca904cb7679663ed36bc.1534432819.git.vdavydov.dev@gmail.com> To: Vladimir Davydov Cc: tarantool-patches@freelists.org List-ID: * Vladimir Davydov [18/08/16 23:03]: > Typically, dump bandwidth varies from 10 MB to 100 MB per second so > let's use 5 MB bucket granularity in this range. Values less than > 10 MB/s can also be observed, because the user can limit disk rate > with box.cfg.snap_io_rate_limit so use 1 MB granularity between 1 MB > and 10 MB and 100 KB granularity between 100 KB and 1 MB. A write rate > greater than 100 MB/s is unlikely in practice, even on very fast disks, > since dump bandwidth is also limited by CPU, so use 100 MB granularity > there. I like the idea and I assume you know what you're doing (aka you measured the positive impact of the new histogram), so ok to push. -- Konstantin Osipov, Moscow, Russia, +7 903 626 22 32 http://tarantool.io - www.twitter.com/kostja_osipov