From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <tarantool-patches-bounce@freelists.org>
Received: from localhost (localhost [127.0.0.1])
	by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTP id 28F102A07F
	for <tarantool-patches@freelists.org>; Fri, 17 Aug 2018 07:34:17 -0400 (EDT)
Received: from turing.freelists.org ([127.0.0.1])
	by localhost (turing.freelists.org [127.0.0.1]) (amavisd-new, port 10024)
	with ESMTP id m12JwAGeEOIS for <tarantool-patches@freelists.org>;
	Fri, 17 Aug 2018 07:34:17 -0400 (EDT)
Received: from smtp62.i.mail.ru (smtp62.i.mail.ru [217.69.128.42])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(No client certificate requested)
	by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTPS id C76422A084
	for <tarantool-patches@freelists.org>; Fri, 17 Aug 2018 07:34:16 -0400 (EDT)
Date: Fri, 17 Aug 2018 14:34:20 +0300
From: Alexander Turenko <alexander.turenko@tarantool.org>
Subject: [tarantool-patches] Re: [PATCH 2/2] sql: remove GLOB from
 Tarantool
Message-ID: <20180817113420.eeolfyg7ztgi5kaa@tkn_work_nb>
References: <cover.1534436835.git.n.tatunov@tarantool.org>
 <4607dc428909e96915e9f0984a7733a0890a3185.1534436836.git.n.tatunov@tarantool.org>
 <76466086-2a5f-8f12-cbc3-4ddf26e30fd9@tarantool.org>
 <20180817112619.2blcl2jz4yhg3xcq@tkn_work_nb>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <20180817112619.2blcl2jz4yhg3xcq@tkn_work_nb>
Sender: tarantool-patches-bounce@freelists.org
Errors-to: tarantool-patches-bounce@freelists.org
Reply-To: tarantool-patches@freelists.org
List-help: <mailto:ecartis@freelists.org?Subject=help>
List-unsubscribe: <tarantool-patches-request@freelists.org?Subject=unsubscribe>
List-software: Ecartis version 1.0.0
List-Id: tarantool-patches <tarantool-patches.freelists.org>
List-subscribe: <tarantool-patches-request@freelists.org?Subject=subscribe>
List-owner: <mailto:>
List-post: <mailto:tarantool-patches@freelists.org>
List-archive: <http://www.freelists.org/archives/tarantool-patches>
To: Alex Khatskevich <avkhatskevich@tarantool.org>
Cc: "N.Tatunov" <n.tatunov@tarantool.org>, tarantool-patches@freelists.org

On Fri, Aug 17, 2018 at 02:26:19PM +0300, Alexander Turenko wrote:
> Hi!
> 
> I have one note.
> 
> WBR, Alexander Turenko.
> 
> On Fri, Aug 17, 2018 at 11:25:14AM +0300, Alex Khatskevich wrote:
> > 
> > 
> > >   		if (sqlite3Utf8CharLen((char *)zEsc, -1) != 1) {
> > >   			sqlite3_result_error(context,
> > > -					     "ESCAPE expression must be a single character",
> > > +					     "ESCAPE expression must be a"
> > > +					     " single character",
> > Do not split error messages at the middle of a sentence. It makes errors
> > ungreppable.
> > Make it <80 somehow different.
> > 
> 
> It was my thought that such rule should be enforced. But I asks Vladimir
> D. and he says that kernel developers don't care about that and show me
> examples.
> 
> Anyway, how you would propose to avoid the string splitting here?
> 
> > > -		sqlite3_result_error(context, "LIKE or GLOB pattern can only"
> > > -				     " contain UTF-8 characters", -1);
> > > +		sqlite3_result_error(context, "LIKE pattern can only contain"
> > > +				     " UTF-8 characters", -1);
> > Do not split error messages at the middle of a sentence. Make it <80 somehow
> > different.
> 
> Same here.
> 

Sorry, missed the following discussion.

If you think we should change our code style, please review it with
mantainers first. But as I said above we already have this point
discussed.

WBR, Alexander Turenko.