From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Date: Mon, 13 Aug 2018 13:20:15 +0300 From: Vladimir Davydov Subject: Re: [tarantool-patches] [PATCH] box-tap: add test to check log_nonblock mode Message-ID: <20180813102015.ejyjs6uvfhmlqrfm@esperanza> References: <20180813071208.40972-1-krishtal.olja@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20180813071208.40972-1-krishtal.olja@gmail.com> To: Olga Arkhangelskaia Cc: tarantool-patches@freelists.org List-ID: On Mon, Aug 13, 2018 at 10:12:08AM +0300, Olga Arkhangelskaia wrote: > We should test log_nonblock mode. In some cases the loss of this flag > leads to tarantool hanging forever (centos/fedora 26/27). > This tests checks such possibility. > > Closes #3615 > --- > https://github.com/tarantool/tarantool/issues/3615 > https://github.com/tarantool/tarantool/tree/OKriw/gh-3615-test-for-hanging-1.10 The test passes even without the patch that fixes log_nonblock behavior. Please make sure it doesn't. Also 'box-tap' is a wrong prefix. The subsystem you're patching is called 'test'. Please fix.