From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <vdavydov.dev@gmail.com>
Date: Wed, 8 Aug 2018 21:27:44 +0300
From: Vladimir Davydov <vdavydov.dev@gmail.com>
Subject: Re: [PATCH v1 1/1] box: fix crash in ncurses on fedora 28
Message-ID: <20180808182744.fa5ijh425oipk7fj@esperanza>
References: <eb5323504261a57a84fa99e8072a89c8c919e1d7.1533736169.git.kshcherbatov@tarantool.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <eb5323504261a57a84fa99e8072a89c8c919e1d7.1533736169.git.kshcherbatov@tarantool.org>
To: Kirill Shcherbatov <kshcherbatov@tarantool.org>
Cc: tarantool-patches@freelists.org
List-ID: <tarantool-patches.dev.tarantool.org>

On Wed, Aug 08, 2018 at 04:52:28PM +0300, Kirill Shcherbatov wrote:
> diff --git a/src/lua/init.c b/src/lua/init.c
> index a0a7f63..217640f 100644
> --- a/src/lua/init.c
> +++ b/src/lua/init.c
> @@ -610,8 +610,10 @@ tarantool_lua_run_script(char *path, bool interactive,
>  	 * To work this problem around we must run init script in
>  	 * a separate fiber.
>  	 */
> -
> -	script_fiber = fiber_new(title, run_script_f);
> +	struct fiber_attr fiber_attr =
> +		{.stack_size = 0x8000 * 4,
> +		 .flags = FIBER_DEFAULT_FLAGS | FIBER_CUSTOM_STACK};
> +	script_fiber = fiber_new_ex(title, &fiber_attr, run_script_f);

AFAIU lbox_console_readline (the function that calls ncurses and crashes
according to the ticket description) can be called from other fibers as
well, e.g.

  require('fiber').create(function() require('console').start() end)

Don't we want to fix that too?