From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <vdavydov.dev@gmail.com>
Date: Wed, 8 Aug 2018 14:23:21 +0300
From: Vladimir Davydov <vdavydov.dev@gmail.com>
Subject: Re: [tarantool-patches] [PATCH v7] Configurable syslog destination
Message-ID: <20180808112321.cgc2u35i6vmieiyn@esperanza>
References: <20180807201603.43949-1-krishtal.olja@gmail.com>
 <20180808090054.iqpibqbdczkzhrzm@esperanza>
 <CAG9q7Ep+VfJEOjgsPbnpt2W-oNnOaVgd=TMJbzUknL3W=RhSow@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <CAG9q7Ep+VfJEOjgsPbnpt2W-oNnOaVgd=TMJbzUknL3W=RhSow@mail.gmail.com>
To: Olga Krishtal <krishtal.olja@gmail.com>
Cc: tarantool-patches@freelists.org
List-ID: <tarantool-patches.dev.tarantool.org>

On Wed, Aug 08, 2018 at 01:40:34PM +0300, Olga Krishtal wrote:
> > > +-- make sure that socket would not block
> > > +while unix_socket:readable(1) do
> >
> > This timeout is way too long. It will increase the test run time by
> > 1 second. Plus 1 second per each socket.readable call below, that is
> > 4 seconds in total.
> >
> > We strive to make our tests run faster whenever possible. AFAIU you
> > don't need to wait for that long. A timeout of say 1 ms (0.001) should
> > do just fine. Please fix the timeout and re-push the test. No need to
> > resend the patch - just reply to this email once you're done.
> >
> >
> 
> Done
> Have pushed branch
> 
> OKriw/gh-3487-syslog-conf-dest-1.10

Please don't drop the mailing list from Cc (use Reply-All).

Also, I suspect that you use GMail web interface. Please don't
as it mangles patches, just like Mail.ru. Use Thunderbird.

Also, you forgot to add 'Closes #3487'. I added it, don't bother.

Also, there were trailing spaces I didn't notice during review:

> +unix_socket:close()                                                         
> +os.remove(path) 

I removed them this time. In order not to miss trailing spaces in
future, please add the following two lines to your .gitconfig:

[color]
	ui = true

(it will make git show/diff highlight trailing spaces)

I pushed the patch to 1.10. Please open a ticket for documentation.
In future write feature documentation requests right in the commit
message (see @TarantoolBot).