From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <vdavydov.dev@gmail.com>
Date: Wed, 8 Aug 2018 13:58:31 +0300
From: Vladimir Davydov <vdavydov.dev@gmail.com>
Subject: Re: [tarantool-patches] [PATCH] replication: fix a failing assert in
 replica_on_applier_disconnect()
Message-ID: <20180808105830.razslkg6whxzbcvq@esperanza>
References: <20180803055905.69108-1-sergepetrenko@tarantool.org>
 <20180803155745.tmndjr52n6igtdno@tarantool.org>
 <81999702-C603-423E-92C9-199CE605FED4@tarantool.org>
 <20180807165031.e2avj7waurok3zpk@esperanza>
 <51F21380-A795-4F40-B3DE-A9770B190BD6@tarantool.org>
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <51F21380-A795-4F40-B3DE-A9770B190BD6@tarantool.org>
To: Sergey Petrenko <sergepetrenko@tarantool.org>
Cc: Kirill Yukhin <kyukhin@tarantool.org>, tarantool-patches@freelists.org
List-ID: <tarantool-patches.dev.tarantool.org>

On Wed, Aug 08, 2018 at 01:10:30PM +0300, Sergey Petrenko wrote:
> 
> 
> > 7 авг. 2018 г., в 19:50, Vladimir Davydov <vdavydov.dev@gmail.com> написал(а):
> > 
> > On Mon, Aug 06, 2018 at 05:14:05PM +0300, Sergey Petrenko wrote:
> >> diff --git a/test/replication/misc.test.lua b/test/replication/misc.test.lua
> >> index c05e52165..27c1a4821 100644
> >> --- a/test/replication/misc.test.lua
> >> +++ b/test/replication/misc.test.lua
> >> @@ -81,3 +81,15 @@ test_run:cmd("switch default")
> >> test_run:drop_cluster(SERVERS)
> >> 
> >> box.schema.user.revoke('guest', 'replication')
> >> +
> >> +-- gh-3510 assertion failure in replica_on_applier_disconnect()
> >> +test_run:cmd('create server er_load1 with script="replication/er_load1.lua"')
> >> +test_run:cmd('create server er_load2 with script="replication/er_load2.lua"')
> >> +test_run:cmd('start server er_load1 with wait=False, wait_load=False')
> >> +test_run:cmd('start server er_load2 with wait=False, wait_load=False')
> >> +require('fiber').sleep(0.5)
> >> +test_run:cmd('stop server er_load1')
> >> +require('fiber').sleep(1)
> > 
> > <kostja-mode>
> >  These sleep()'s are way too long. They will make our tests run forever.
> >  Please change to 0.00001 or smaller or rewrite the test so that you do
> >  not need them.
> > </kostja-mode>
> 
> Hi! Thank you for review.
> Fixed. Here’s the new diff:
> 
>  src/box/replication.cc         |  4 ++++
>  test/replication/er_load.lua   | 25 +++++++++++++++++++++++++
>  test/replication/er_load1.lua  |  1 +
>  test/replication/er_load2.lua  |  1 +
>  test/replication/misc.result   | 32 ++++++++++++++++++++++++++++++++
>  test/replication/misc.test.lua | 12 ++++++++++++
>  6 files changed, 75 insertions(+)
>  create mode 100644 test/replication/er_load.lua
>  create mode 120000 test/replication/er_load1.lua
>  create mode 120000 test/replication/er_load2.lua
> 

With your patch replication/on_replace test hangs on Travis CI for
test/coverage targets (I tried to restart, but it doesn't help).
Actually, it hangs on my local machine too (debug build). Please fix.