From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTP id CF5C8268AB for ; Tue, 7 Aug 2018 07:39:50 -0400 (EDT) Received: from turing.freelists.org ([127.0.0.1]) by localhost (turing.freelists.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id iwX-DvHa7VfW for ; Tue, 7 Aug 2018 07:39:50 -0400 (EDT) Received: from smtp42.i.mail.ru (smtp42.i.mail.ru [94.100.177.102]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTPS id 8B0B72646D for ; Tue, 7 Aug 2018 07:39:50 -0400 (EDT) Received: from [185.6.245.156] (port=58091 helo=tarantool.org) by smtp42.i.mail.ru with esmtpa (envelope-from ) id 1fn0L6-0004dc-WF for tarantool-patches@freelists.org; Tue, 07 Aug 2018 14:39:49 +0300 Date: Tue, 7 Aug 2018 14:39:48 +0300 From: Kirill Yukhin Subject: [tarantool-patches] Re: [PATCH] box: serialize calls to box.cfg Message-ID: <20180807113948.vdkas4llffhspbh5@tarantool.org> References: <619fdb85de8edff29334abcf75ffec7aa8647723.1533634796.git.vdavydov.dev@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <619fdb85de8edff29334abcf75ffec7aa8647723.1533634796.git.vdavydov.dev@gmail.com> Sender: tarantool-patches-bounce@freelists.org Errors-to: tarantool-patches-bounce@freelists.org Reply-To: tarantool-patches@freelists.org List-help: List-unsubscribe: List-software: Ecartis version 1.0.0 List-Id: tarantool-patches List-subscribe: List-owner: List-post: List-archive: To: tarantool-patches@freelists.org Hello, On 07 авг 12:43, Vladimir Davydov wrote: > It is dangerous to call box.cfg() concurrently from different fibers. > For example, replication configuration uses static variables and yields > so calling it concurrently can result in a crash. To make sure it never > happens, let's protect box.cfg() with a lock. > > Closes #3606 > --- > https://github.com/tarantool/tarantool/issues/3606 > https://github.com/tarantool/tarantool/tree/dv/gh-3606-concurrent-replication-cfg-fix I've merged final version of the patch into 1.9 branch. -- Regards, Kirill Yukhin