From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Date: Fri, 3 Aug 2018 18:57:45 +0300 From: Kirill Yukhin Subject: Re: [tarantool-patches] [PATCH] replication: fix a failing assert in replica_on_applier_disconnect() Message-ID: <20180803155745.tmndjr52n6igtdno@tarantool.org> References: <20180803055905.69108-1-sergepetrenko@tarantool.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20180803055905.69108-1-sergepetrenko@tarantool.org> To: tarantool-patches@freelists.org Cc: vdavydov.dev@gmail.com, Serge Petrenko List-ID: Hello Serge, On 03 авг 08:59, Serge Petrenko wrote: > One possible case when two applier errors happen one after another > wasn't handled in replica_on_applier_disconnect(), which lead to > occasional test failures and crashes. Handle this case. > > Part of #3510 > --- > This patch fixes an assertion fail, submitted by @locker in issue comments. > I wasn't able to reproduce 2 failures reported in the issue itself, and asked > for comments, but got no answer. I also couldn't fix the latter 2 > failures just by looking at code. > > https://github.com/tarantool/tarantool/tree/sergepetrenko/gh-3510-replication-asserts-fail > https://github.com/tarantool/tarantool/issues/3510 Could you pls prepare a regression test as well? -- Regards, Kirill Yukhin