From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <vdavydov.dev@gmail.com>
Date: Fri, 3 Aug 2018 16:47:14 +0300
From: Vladimir Davydov <vdavydov.dev@gmail.com>
Subject: Re: [tarantool-patches] [PATCH 1/1] Allow to ignore space formats
 via command line option
Message-ID: <20180803134714.3eosv3bs2l7q5bxw@esperanza>
References: <48493aa9dc94ded22aee27178c342343aa1b8b65.1533300304.git.v.shpilevoy@tarantool.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <48493aa9dc94ded22aee27178c342343aa1b8b65.1533300304.git.v.shpilevoy@tarantool.org>
To: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>
Cc: tarantool-patches@freelists.org, kostja@tarantool.org
List-ID: <tarantool-patches.dev.tarantool.org>

On Fri, Aug 03, 2018 at 03:46:26PM +0300, Vladislav Shpilevoy wrote:
> It is a common case that an instance is running on a version
> 1.6.*, then is upgraded to 1.9 with box.schema.upgrade(). But
> some of users has malformed space formats, and some of them got
> and ignored errors on box.schema.upgrade(). Such half-upgraded
> data can not be used to start a new version due to format
> violations, and can not be rolled back because some of new system
> spaces managed to be created. And we can not repair raw xlogs and
> snapshots because we have no such tools and they are zipped.
> 
> So it would be useful to have a command line option
> --ignore-space-formats. It would allow to start an instance on
> the spaces with malformed formats, fix them, create a snapshot
> and then start with the formats turned on.
> 
> Closes #3605
> 
> @TarantoolBot document
> Title: Command line option '--ignore-space-formats'
> The option allows to turn off space formats validation before
> the instance is started. Usefull to fix malformed formats after
> an upgrade from version < 1.7.5 to >= 1.7.5.

Why a command line option? Why not a box.cfg parameter?
Or, even better, box.cfg.force_recovery?