From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTP id 8E33E25170 for ; Thu, 2 Aug 2018 10:09:51 -0400 (EDT) Received: from turing.freelists.org ([127.0.0.1]) by localhost (turing.freelists.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 02hWIc7ATHRl for ; Thu, 2 Aug 2018 10:09:51 -0400 (EDT) Received: from smtp57.i.mail.ru (smtp57.i.mail.ru [217.69.128.37]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTPS id 4E6DB22474 for ; Thu, 2 Aug 2018 10:09:51 -0400 (EDT) Date: Thu, 2 Aug 2018 17:09:49 +0300 From: Kirill Yukhin Subject: [tarantool-patches] Re: [PATCH] sql: remove meaningless triggerE test Message-ID: <20180802140949.tsaim3unuuet5rjf@tarantool.org> References: <20180802112918.90330-1-korablev@tarantool.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20180802112918.90330-1-korablev@tarantool.org> Sender: tarantool-patches-bounce@freelists.org Errors-to: tarantool-patches-bounce@freelists.org Reply-To: tarantool-patches@freelists.org List-help: List-unsubscribe: List-software: Ecartis version 1.0.0 List-Id: tarantool-patches List-subscribe: List-owner: List-post: List-archive: To: Nikita Pettik Cc: tarantool-patches@freelists.org Hello, On 02 авг 14:29, Nikita Pettik wrote: > Originally, SQLite doesn't allow to use binding parameters in trigger's > body. triggerE test checks only this taboo. However, binding mechanism is > not properly implemented now, so this test seems to be useless and can > be removed. > --- > Branch: https://github.com/tarantool/tarantool/tree/np/remove-useless-trigger-test > Issue: no corresponding issue Checked into 2.0 as obvious. -- Regards, Kirill Yukhin