From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Date: Wed, 1 Aug 2018 15:52:19 +0300 From: Vladimir Davydov Subject: Re: [tarantool-patches] [PATCH v5 2/4] box-tap: test valid log configuration Message-ID: <20180801125219.ydwnn2jorhw3ebbj@esperanza> References: <20180731171519.74073-1-arkholga@tarantool.org> <20180731171519.74073-3-arkholga@tarantool.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20180731171519.74073-3-arkholga@tarantool.org> To: Olga Arkhangelskaia Cc: tarantool-patches@freelists.org List-ID: This test fails on Travis CI. Looks like syslog daemon blocks connections for some reason. I don't think it's worth investigating, because you test syslog configuration in patches 3 and 4 anyway. Let's just drop it? On Tue, Jul 31, 2018 at 08:15:17PM +0300, Olga Arkhangelskaia wrote: > Test case checks that valid log configuration is not broken. > > In scope of gh-3487 > --- > test/box-tap/cfg.test.lua | 10 +++++++++- > 1 file changed, 9 insertions(+), 1 deletion(-) > > diff --git a/test/box-tap/cfg.test.lua b/test/box-tap/cfg.test.lua > index ffafdbe42..67e4c3af9 100755 > --- a/test/box-tap/cfg.test.lua > +++ b/test/box-tap/cfg.test.lua > @@ -6,7 +6,7 @@ local socket = require('socket') > local fio = require('fio') > local uuid = require('uuid') > local msgpack = require('msgpack') > -test:plan(95) > +test:plan(96) > > -------------------------------------------------------------------------------- > -- Invalid values > @@ -464,5 +464,13 @@ code = string.format(code_fmt, dir, instance_uuid, uuid.new()) > test:is(run_script(code), PANIC, "replicaset_uuid mismatch") > fio.rmdir(dir) > > +-- > +-- Check syslog configuration > +-- (syslog daemon may be not started hence use pcall) > +-- > +code = [[pcall(box.cfg, {log = 'syslog:identity=tarantool'}) > +]] > +test:is(run_script(code), 0, "syslog log configuration") > + > test:check() > os.exit(0) > -- > 2.14.3 (Apple Git-98) > >