From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <vdavydov.dev@gmail.com>
Date: Wed, 1 Aug 2018 15:39:57 +0300
From: Vladimir Davydov <vdavydov.dev@gmail.com>
Subject: Re: [tarantool-patches] [PATCH v2 2/2] box-tap: test to check logger
 invalid config.
Message-ID: <20180801123957.ernpjs7cnhef54co@esperanza>
References: <20180801110710.10292-1-arkholga@tarantool.org>
 <20180801110710.10292-3-arkholga@tarantool.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20180801110710.10292-3-arkholga@tarantool.org>
To: Olga Arkhangelskaia <arkholga@tarantool.org>
Cc: tarantool-patches@freelists.org
List-ID: <tarantool-patches.dev.tarantool.org>

On Wed, Aug 01, 2018 at 02:07:10PM +0300, Olga Arkhangelskaia wrote:
> Added test to check that logger doesn't except invalid
> configuration.
> 
> In scope of gh-3553
> ---
>  test/box-tap/cfg.test.lua | 5 ++++-
>  1 file changed, 4 insertions(+), 1 deletion(-)

We don't submit tests separately. Please squash this patch in patch 1.

You also changed the way box.cfg{log_format=...} works when called
after initial configuration: now it returns an error if the format is
incompatible with the logger type. Please add a test case for this, too.

> 
> diff --git a/test/box-tap/cfg.test.lua b/test/box-tap/cfg.test.lua
> index ea6f4d646..2d77c9f3e 100755
> --- a/test/box-tap/cfg.test.lua
> +++ b/test/box-tap/cfg.test.lua
> @@ -6,7 +6,7 @@ local socket = require('socket')
>  local fio = require('fio')
>  local uuid = require('uuid')
>  local msgpack = require('msgpack')
> -test:plan(95)
> +test:plan(98)
>  
>  --------------------------------------------------------------------------------
>  -- Invalid values
> @@ -39,6 +39,8 @@ invalid('listen', '//!')
>  invalid('log', ':')
>  invalid('log', 'syslog:xxx=')
>  invalid('log_level', 'unknown')
> +invalid('log_format', "xxx")
> +invalid('log', ":test:")
>  invalid('vinyl_memory', -1)
>  invalid('vinyl_read_threads', 0)
>  invalid('vinyl_write_threads', 1)
> @@ -56,6 +58,7 @@ end
>  
>  invalid_combinations("log, log_nonblock", {log = "1.log", log_nonblock = true})
>  invalid_combinations("log, log_format", {log = "syslog:identity=tarantool", log_format = 'json'})
> +invalid_combinations("log, log_nonblock", {log_nonblock = true})
>  
>  test:is(type(box.cfg), 'function', 'box is not started')