From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Date: Tue, 31 Jul 2018 23:48:56 +0300 From: Konstantin Osipov Subject: Re: [PATCH 10/25] vinyl: do not free pending tasks on shutdown Message-ID: <20180731204856.GN15235@chai> References: <3d95ff7e5ed6ba2ce59efcb2385e1bb56fa84845.1532689066.git.vdavydov.dev@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <3d95ff7e5ed6ba2ce59efcb2385e1bb56fa84845.1532689066.git.vdavydov.dev@gmail.com> To: Vladimir Davydov Cc: tarantool-patches@freelists.org List-ID: * Vladimir Davydov [18/07/27 16:55]: > This is a prerequisite for switching scheduler-worker communication from > pthread mutex/cond to cbus, which in turn is needed to generate and send > deferred DELETEs from workers back to tx (#2129). > > After this patch, pending tasks will be leaked on shutdown. This is OK, > as we leak a lot of objects on shutdown anyway. The proper way of fixing > this leak would be to rework shutdown without atexit() so that we can > use cbus till the very end. > > Needed for #2129 > --- OK to push. -- Konstantin Osipov, Moscow, Russia, +7 903 626 22 32 http://tarantool.io - www.twitter.com/kostja_osipov