From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Date: Tue, 31 Jul 2018 23:47:37 +0300 From: Konstantin Osipov Subject: Re: [PATCH 09/25] vinyl: store full tuples in secondary index cache Message-ID: <20180731204737.GM15235@chai> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: To: Vladimir Davydov Cc: tarantool-patches@freelists.org List-ID: * Vladimir Davydov [18/07/27 16:55]: > Currently, both vy_read_iterator_next() and vy_point_lookup() add the > returned tuple to the tuple cache. As a result, we store partial tuples > in a secondary index tuple cache although we could store full tuples > (we have to retrieve them anyway when reading a secondary index). This > means wasting memory. Besides, when the #2129 gets implemented, there > will be tuples in a secondary index that have to be skipped as they have > been overwritten in the primary index. Caching them would be inefficient > and error prone. So let's call vy_cache_add() from the upper level and > add only full tuples to the cache. OK to push. -- Konstantin Osipov, Moscow, Russia, +7 903 626 22 32 http://tarantool.io - www.twitter.com/kostja_osipov