From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Date: Tue, 31 Jul 2018 23:38:13 +0300 From: Konstantin Osipov Subject: Re: [RFC PATCH 12/23] vinyl: do not pass region explicitly to write iterator functions Message-ID: <20180731203813.GF15235@chai> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1542cec64f8dc936a7cf09a33ca3964f1297c3b0.1531065648.git.vdavydov.dev@gmail.com> References: <1542cec64f8dc936a7cf09a33ca3964f1297c3b0.1531065648.git.vdavydov.dev@gmail.com> To: Vladimir Davydov Cc: tarantool-patches@freelists.org List-ID: * Vladimir Davydov [18/07/08 22:53]: > This is not necessary, as we can use fiber()->gc, as we usually do. The reason Vlad is passing it explicitly is that if we plan to make transactions interactive, we're going to end up with more than one transaction per fiber. So it really should be tx->gc (non-existent at the moment), not fiber->gc. I think Vlad is passing it around explicitly as a mental note to self. It's OK to push. 1.0 -- Konstantin Osipov, Moscow, Russia, +7 903 626 22 32 http://tarantool.io - www.twitter.com/kostja_osipov