From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Date: Tue, 31 Jul 2018 23:36:34 +0300 From: Konstantin Osipov Subject: Re: [RFC PATCH 11/23] xrow: allow to store flags in DML requests Message-ID: <20180731203634.GE15235@chai> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <6fdd265563e64d59809f2ea285e74da73154abe4.1531065648.git.vdavydov.dev@gmail.com> References: <6fdd265563e64d59809f2ea285e74da73154abe4.1531065648.git.vdavydov.dev@gmail.com> To: Vladimir Davydov Cc: tarantool-patches@freelists.org List-ID: * Vladimir Davydov [18/07/08 22:52]: > In the scope of #2129 we need to mark REPLACE statements for which we > generated DELETE in secondary indexes so that we don't generate DELETE > again on compaction. We also need to mark DELETE statements that were > generated on compaction so that we can skip them on SELECT. > > Let's add flags field to struct vy_stmt. Flags are stored both in memory > and on disk so to encode/decode them we also need to add a new iproto > key (IPROTO_FLAGS) and the corresponding field to struct request. We have been avoiding IPROTO_FLAGS so far. Can we make this member engine-local, i.e. make sure it's only visible/usable for vinyl rows? -- Konstantin Osipov, Moscow, Russia, +7 903 626 22 32 http://tarantool.io - www.twitter.com/kostja_osipov