From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Date: Tue, 31 Jul 2018 23:28:52 +0300 From: Konstantin Osipov Subject: Re: [RFC PATCH 07/23] vinyl: refactor unique check Message-ID: <20180731202852.GC15235@chai> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <3cb0d304b76b6594421cbcf178c36d540a39f83f.1531065648.git.vdavydov.dev@gmail.com> References: <3cb0d304b76b6594421cbcf178c36d540a39f83f.1531065648.git.vdavydov.dev@gmail.com> To: Vladimir Davydov Cc: tarantool-patches@freelists.org List-ID: * Vladimir Davydov [18/07/08 22:52]: > For the sake of further patches, let's do some refactoring: > - Rename vy_check_is_unique to vy_check_is_unique_primary and use it > only for checking the unique constraint of primary indexes. Also, > make it return immediately if the primary index doesn't need > uniqueness check, like vy_check_is_unique_secondary does. > - Open-code uniqueness check in vy_check_is_unique_secondary instead of > using vy_check_is_unique. > - Reduce indentation level of vy_check_is_unique_secondary by inverting > the if statement. Pushed. -- Konstantin Osipov, Moscow, Russia, +7 903 626 22 32 http://tarantool.io - www.twitter.com/kostja_osipov