From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Date: Tue, 31 Jul 2018 23:28:01 +0300 From: Konstantin Osipov Subject: Re: [RFC PATCH 05/23] vinyl: fold vy_replace_one and vy_replace_impl Message-ID: <20180731202801.GA15235@chai> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <6a7cc54c8ed2fa0c855210359eb4756537ec064e.1531065648.git.vdavydov.dev@gmail.com> References: <6a7cc54c8ed2fa0c855210359eb4756537ec064e.1531065648.git.vdavydov.dev@gmail.com> To: Vladimir Davydov Cc: tarantool-patches@freelists.org List-ID: * Vladimir Davydov [18/07/08 22:52]: > There's no point in separating REPLACE path between the cases when > the space has secondary indexes and when it only has the primary > index, because they are quite similar. Let's fold vy_replace_one > and vy_replace_impl into vy_replace to remove code duplication. > --- > src/box/vinyl.c | 219 +++++++++++++++++--------------------------------------- Pushed. -- Konstantin Osipov, Moscow, Russia, +7 903 626 22 32 http://tarantool.io - www.twitter.com/kostja_osipov