From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTP id 6BFE625201 for ; Tue, 31 Jul 2018 06:56:36 -0400 (EDT) Received: from turing.freelists.org ([127.0.0.1]) by localhost (turing.freelists.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id Vc4hi7jCR03w for ; Tue, 31 Jul 2018 06:56:36 -0400 (EDT) Received: from smtp57.i.mail.ru (smtp57.i.mail.ru [217.69.128.37]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTPS id 1F1D725022 for ; Tue, 31 Jul 2018 06:56:36 -0400 (EDT) Date: Tue, 31 Jul 2018 13:56:33 +0300 From: Kirill Yukhin Subject: [tarantool-patches] Re: [PATCH] sql: remove pragma schema_version Message-ID: <20180731105633.o5aco7usbtva6iqr@tarantool.org> References: <836ab78c9ea4741455b7c8c226bd7919f635af6f.1533034378.git.kyukhin@tarantool.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <836ab78c9ea4741455b7c8c226bd7919f635af6f.1533034378.git.kyukhin@tarantool.org> Sender: tarantool-patches-bounce@freelists.org Errors-to: tarantool-patches-bounce@freelists.org Reply-To: tarantool-patches@freelists.org List-help: List-unsubscribe: List-software: Ecartis version 1.0.0 List-Id: tarantool-patches List-subscribe: List-owner: List-post: List-archive: To: v.shpilevoy@tarantool.org Cc: tarantool-patches@freelists.org On 31 июл 13:54, Kirill Yukhin wrote: > This pragma is dead and produces nothing else but segfault. > Along w/ this pragma, remove now dead opcodes which set/read > schema_version and all related routines. > Also, improve opcode generation script. > > Part of #3541 > --- > Branch: https://github.com/tarantool/tarantool/commits/kyukhin/gh-3541-remove-schema-version-pragma > Issue: https://github.com/tarantool/tarantool/issues/3541 Removed junk modified src/box/sql/vdbe.c modified src/box/sql/vdbe.c @@ -3079,7 +3079,7 @@ case OP_TTransaction: { /* Opcode: OpenRead P1 P2 P3 P4 P5 * Synopsis: index id = P2, space ptr = P4 * -\ * Open a cursor for a space specified by pointer in P4 and index + * Open a cursor for a space specified by pointer in P4 and index * id in P2. Give the new cursor an identifier of P1. The P1 * values need not be contiguous but all P1 values should be * small integers. It is an error for P1 to be negative. -- Regards, Kirill Yukhin