From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <tarantool-patches-bounce@freelists.org>
Received: from localhost (localhost [127.0.0.1])
	by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTP id A018627718
	for <tarantool-patches@freelists.org>; Thu, 26 Jul 2018 17:32:14 -0400 (EDT)
Received: from turing.freelists.org ([127.0.0.1])
	by localhost (turing.freelists.org [127.0.0.1]) (amavisd-new, port 10024)
	with ESMTP id ZeIYFlv0rNlh for <tarantool-patches@freelists.org>;
	Thu, 26 Jul 2018 17:32:14 -0400 (EDT)
Received: from smtp32.i.mail.ru (smtp32.i.mail.ru [94.100.177.92])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(No client certificate requested)
	by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTPS id 5639C27717
	for <tarantool-patches@freelists.org>; Thu, 26 Jul 2018 17:32:14 -0400 (EDT)
Date: Fri, 27 Jul 2018 00:32:11 +0300
From: Konstantin Osipov <kostja@tarantool.org>
Subject: [tarantool-patches] Re: [PATCH] lua: fix fio.rmtree to work with
 non empty dirs
Message-ID: <20180726213211.GA18822@chai>
References: <20180716161543.14753-1-k.belyavskiy@tarantool.org>
 <20180718034344.tolxqd4nb3o5bafq@tkn_work_nb>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20180718034344.tolxqd4nb3o5bafq@tkn_work_nb>
Sender: tarantool-patches-bounce@freelists.org
Errors-to: tarantool-patches-bounce@freelists.org
Reply-To: tarantool-patches@freelists.org
List-help: <mailto:ecartis@freelists.org?Subject=help>
List-unsubscribe: <tarantool-patches-request@freelists.org?Subject=unsubscribe>
List-software: Ecartis version 1.0.0
List-Id: tarantool-patches <tarantool-patches.freelists.org>
List-subscribe: <tarantool-patches-request@freelists.org?Subject=subscribe>
List-owner: <mailto:>
List-post: <mailto:tarantool-patches@freelists.org>
List-archive: <http://www.freelists.org/archives/tarantool-patches>
To: tarantool-patches@freelists.org
Cc: Konstantin Belyavskiy <k.belyavskiy@tarantool.org>

* Alexander Turenko <alexander.turenko@tarantool.org> [18/07/18 09:46]:
> Hi Kostya!
> 
> The patch looks good for me except one tiny comment.
> 

I pushed an updated patch (it was not sent to this list), but
contains a fix for this review comment.

> WBR, Alexander Turenko.
> 
> > index 0850413d9..14e0fb72c 100644
> > --- a/test/app/fio.test.lua
> > +++ b/test/app/fio.test.lua
> > @@ -131,6 +131,13 @@ fio.rmdir(dir2)
> >  
> >  { fio.unlink(file1), fio.unlink(file2), fio.unlink(file3), fio.unlink(file4) }
> >  { fio.unlink(file1), fio.unlink(file2), fio.unlink(file3), fio.unlink(file4) }
> > +
> > +-- gh-3258 rmtree should remove directories with files
> > +fio.mktree('tmp2/tmp3/tmp4')
> > +fh = fio.open('tmp2/tmp3/tmp4/tmp.txt', {'O_RDWR', 'O_CREAT'})
> > +fh:close()
> > +fio.rmtree('tmp2')
> > +
> 
> I think it would be good to check that the directory really disappears
> (via fio.listdir()).

-- 
Konstantin Osipov, Moscow, Russia, +7 903 626 22 32
http://tarantool.io - www.twitter.com/kostja_osipov