From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <tarantool-patches-bounce@freelists.org>
Received: from localhost (localhost [127.0.0.1])
	by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTP id 8E84726960
	for <tarantool-patches@freelists.org>; Thu, 26 Jul 2018 16:06:21 -0400 (EDT)
Received: from turing.freelists.org ([127.0.0.1])
	by localhost (turing.freelists.org [127.0.0.1]) (amavisd-new, port 10024)
	with ESMTP id cdUOM4oTscnU for <tarantool-patches@freelists.org>;
	Thu, 26 Jul 2018 16:06:21 -0400 (EDT)
Received: from smtp57.i.mail.ru (smtp57.i.mail.ru [217.69.128.37])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(No client certificate requested)
	by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTPS id B1E47274F6
	for <tarantool-patches@freelists.org>; Thu, 26 Jul 2018 16:06:20 -0400 (EDT)
Date: Thu, 26 Jul 2018 23:06:18 +0300
From: Konstantin Osipov <kostja@tarantool.org>
Subject: [tarantool-patches] Re: [PATCH v3] Make access_check_ddl check for entity privileges.
Message-ID: <20180726200618.GA26714@chai>
References: <20180719193533.23249-1-sergepetrenko@tarantool.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20180719193533.23249-1-sergepetrenko@tarantool.org>
Sender: tarantool-patches-bounce@freelists.org
Errors-to: tarantool-patches-bounce@freelists.org
Reply-To: tarantool-patches@freelists.org
List-help: <mailto:ecartis@freelists.org?Subject=help>
List-unsubscribe: <tarantool-patches-request@freelists.org?Subject=unsubscribe>
List-software: Ecartis version 1.0.0
List-Id: tarantool-patches <tarantool-patches.freelists.org>
List-subscribe: <tarantool-patches-request@freelists.org?Subject=subscribe>
List-owner: <mailto:>
List-post: <mailto:tarantool-patches@freelists.org>
List-archive: <http://www.freelists.org/archives/tarantool-patches>
To: Serge Petrenko <sergepetrenko@tarantool.org>
Cc: tarantool-patches@freelists.org

* Serge Petrenko <sergepetrenko@tarantool.org> [18/07/19 23:28]:
> Function access_check_ddl checked only for universal access, thus
> granting entity or singe object access to a user would have no effect in
> scope of this function.
> Fix this by adding entity access checks.
> 
> Also attaching an existing sequence to a space checked for
> create privilege on both space and sequence
> (instead of read + write on sequence). Fixed it and changed the tests
> accordingly.
> 
> Closes #3516

Pushed.


-- 
Konstantin Osipov, Moscow, Russia, +7 903 626 22 32
http://tarantool.io - www.twitter.com/kostja_osipov