From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTP id 65B5C2687A for ; Tue, 24 Jul 2018 12:59:13 -0400 (EDT) Received: from turing.freelists.org ([127.0.0.1]) by localhost (turing.freelists.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 5C4DJaQYNxWZ for ; Tue, 24 Jul 2018 12:59:13 -0400 (EDT) Received: from smtp63.i.mail.ru (smtp63.i.mail.ru [217.69.128.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTPS id AB2311FFC1 for ; Tue, 24 Jul 2018 12:59:12 -0400 (EDT) Date: Tue, 24 Jul 2018 19:54:04 +0300 From: Kirill Yukhin Subject: [tarantool-patches] Re: Re[2]: [PATCH] add FindICONV and iconv wrapper Message-ID: <20180724165404.n2m2djbikalosoav@tarantool.org> References: <20180720165052.8631-1-k.belyavskiy@tarantool.org> <2411664.Jxh9JcPWzN@localhost> <1532443175.97240990@f404.i.mail.ru> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1532443175.97240990@f404.i.mail.ru> Sender: tarantool-patches-bounce@freelists.org Errors-to: tarantool-patches-bounce@freelists.org Reply-To: tarantool-patches@freelists.org List-help: List-unsubscribe: List-software: Ecartis version 1.0.0 List-Id: tarantool-patches List-subscribe: List-owner: List-post: List-archive: To: tarantool-patches@freelists.org Cc: Georgy Kirichenko Hello, On 24 июл 17:39, Konstantin Belyavskiy wrote: > Georgy, thank you for the review. > Please take a look at updated patch. List of changes: > - update wrong comment > - rename file and functions iconv_wrap* to tnt_iconv* > - remove unnecessary include file Could you pls attach an updated patch in future mails? -- Regards, Kirill Yukhin