From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Date: Tue, 24 Jul 2018 11:37:01 +0300 From: Vladimir Davydov Subject: Re: [tarantool-patches] Re: [PATCH] replication: unregister replica with gc if deleted from cluster Message-ID: <20180724083701.hpibyh54jf35wd6r@esperanza> References: <20180723203019.GE10149@chai> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20180723203019.GE10149@chai> To: Konstantin Osipov Cc: tarantool-patches@freelists.org List-ID: On Mon, Jul 23, 2018 at 11:30:19PM +0300, Konstantin Osipov wrote: > * Vladimir Davydov [18/07/23 00:34]: > > > When a replica is removed from the cluster table, the corresponding > > replica struct isn't destroyed unless both the relay and the applier > > attached to it are stopped, see replica_clear_id(). Since replica struct > > is a holder of the garbage collection state, this means that in case an > > evicted replica has an applier or a relay that fails to exit for some > > reason, garbage collection will hang. > > I failed to merge this into 1.10, please help. Done.