From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTP id E0C69238C3 for ; Mon, 23 Jul 2018 16:30:21 -0400 (EDT) Received: from turing.freelists.org ([127.0.0.1]) by localhost (turing.freelists.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id GJawB4UNvUs0 for ; Mon, 23 Jul 2018 16:30:21 -0400 (EDT) Received: from smtp17.mail.ru (smtp17.mail.ru [94.100.176.154]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTPS id 9BD1A23521 for ; Mon, 23 Jul 2018 16:30:21 -0400 (EDT) Received: from [185.6.245.178] (port=52496 helo=atlas.local) by smtp17.mail.ru with esmtpa (envelope-from ) id 1fhhTH-0001Oq-Ss for tarantool-patches@freelists.org; Mon, 23 Jul 2018 23:30:19 +0300 Date: Mon, 23 Jul 2018 23:30:19 +0300 From: Konstantin Osipov Subject: [tarantool-patches] Re: [PATCH] replication: unregister replica with gc if deleted from cluster Message-ID: <20180723203019.GE10149@chai> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Sender: tarantool-patches-bounce@freelists.org Errors-to: tarantool-patches-bounce@freelists.org Reply-To: tarantool-patches@freelists.org List-help: List-unsubscribe: List-software: Ecartis version 1.0.0 List-Id: tarantool-patches List-subscribe: List-owner: List-post: List-archive: To: tarantool-patches@freelists.org * Vladimir Davydov [18/07/23 00:34]: > When a replica is removed from the cluster table, the corresponding > replica struct isn't destroyed unless both the relay and the applier > attached to it are stopped, see replica_clear_id(). Since replica struct > is a holder of the garbage collection state, this means that in case an > evicted replica has an applier or a relay that fails to exit for some > reason, garbage collection will hang. I failed to merge this into 1.10, please help. > -- Konstantin Osipov, Moscow, Russia, +7 903 626 22 32 http://tarantool.io - www.twitter.com/kostja_osipov