From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Date: Mon, 23 Jul 2018 23:19:11 +0300 From: Konstantin Osipov Subject: Re: [PATCH v3 07/11] replication: rebootstrap instance on startup if it fell behind Message-ID: <20180723201911.GB10149@chai> References: <64016c63c3727e5df2e4495fe1de52eb8ca5d2eb.1531598427.git.vdavydov.dev@gmail.com> <20180719071903.GG11373@chai> <20180719100439.bmcm4txbbjb2xjjf@esperanza> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20180719100439.bmcm4txbbjb2xjjf@esperanza> To: Vladimir Davydov Cc: tarantool-patches@freelists.org List-ID: * Vladimir Davydov [18/07/19 14:07]: > > What about this? > > : 2018-07-19 12:53:45.195 [19455] main/101/replica I> can't follow [::1]:47383: required {1: 8} available {1: 12} > : 2018-07-19 12:53:45.195 [19455] main/101/replica C> replica is too old, initiating rebootstrap > : 2018-07-19 12:53:45.195 [19455] main/101/replica I> bootstrapping replica from [::1]:47383 It would be better if we use uuid or server id as identifiers (can't follow or rebootstrapping from ), providing URIs only as additinal information. > : 2018-07-19 12:53:46.546 [19493] main/101/replica I> can't follow [::1]:47383: required {1: 17, 2: 1} available {1: 20} > : 2018-07-19 12:53:46.546 [19493] main/101/replica I> can't rebootstrap from [::1]:47383: replica has local rows: local {1: 17, 2: 1} remote {1: 23} > : 2018-07-19 12:53:46.546 [19493] main/101/replica I> recovery start > > The diff is below. Note, apart from logging I also changed the logic > of the rebootstrap trigger a bit: now we proceed to rebootstrap only > if none of the configured masters has rows needed by the instance. Ack. > > I haven't pushed the patch to the branch yet. If you're okay with it, > I'll squash it into the original patch, rebase the whole series, and > then update the remote branch. OK, the patch itself is OK. -- Konstantin Osipov, Moscow, Russia, +7 903 626 22 32 http://tarantool.io - www.twitter.com/kostja_osipov