From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Date: Sat, 21 Jul 2018 15:26:52 +0300 From: Vladimir Davydov Subject: Re: [PATCH 5/6] space: call before_replace trigger even if space has no indexes Message-ID: <20180721122652.rll2tshmcsbhzsfn@esperanza> References: <35469846b9a1e53af007f600a120c716478d253b.1532107326.git.vdavydov.dev@gmail.com> <20180720183909.GF4827@chai> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20180720183909.GF4827@chai> To: Konstantin Osipov Cc: tarantool-patches@freelists.org List-ID: On Fri, Jul 20, 2018 at 09:39:09PM +0300, Konstantin Osipov wrote: > * Vladimir Davydov [18/07/20 20:45]: > > Needed for blackhole spaces (see the next patch), which don't support > > indexes per se, but still may have a before_replace trigger installed. > > Why do you need to enable before replace triggers for blackhole? Why not? before_replace can be installed on a blackhole space so I guess it should work, otherwise it may raise questions. > What's wrong with on_replace triggers? Nothing wrong at all. They work as well.