From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTP id 280FC274F0 for ; Fri, 20 Jul 2018 11:10:31 -0400 (EDT) Received: from turing.freelists.org ([127.0.0.1]) by localhost (turing.freelists.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 28jkF35Qy8ht for ; Fri, 20 Jul 2018 11:10:31 -0400 (EDT) Received: from smtp59.i.mail.ru (smtp59.i.mail.ru [217.69.128.39]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTPS id CCFF320FC9 for ; Fri, 20 Jul 2018 11:10:30 -0400 (EDT) Date: Fri, 20 Jul 2018 17:40:33 +0300 From: Kirill Yukhin Subject: [tarantool-patches] Re: [PATCH] sql: refactor primary index creation Message-ID: <20180720144033.lfmsbbx52ls3lekr@tarantool.org> References: <20180720130806.mjf7ww3qt4t7maot@tarantool.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: Sender: tarantool-patches-bounce@freelists.org Errors-to: tarantool-patches-bounce@freelists.org Reply-To: tarantool-patches@freelists.org List-help: List-unsubscribe: List-software: Ecartis version 1.0.0 List-Id: tarantool-patches List-subscribe: List-owner: List-post: List-archive: To: "n.pettik" Cc: tarantool-patches@freelists.org Hello Nikita, On 20 июл 17:34, n.pettik wrote: > LGTM, except for 1 comment. Comment fixed and comitted to 2.0 branch. -- Regards, Kirill Yukhin