From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Date: Thu, 19 Jul 2018 15:26:16 +0300 From: Vladimir Davydov Subject: Re: [tarantool-patches] [PATCH v2 2/2] Added strdup fail checks in say Message-ID: <20180719122615.yfo4jvionwdhyvum@esperanza> References: <20180719105449.49710-1-arkholga@tarantool.org> <20180719105449.49710-2-arkholga@tarantool.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20180719105449.49710-2-arkholga@tarantool.org> To: Olga Arkhangelskaia Cc: tarantool-patches@freelists.org List-ID: On Thu, Jul 19, 2018 at 01:54:49PM +0300, Olga Arkhangelskaia wrote: > Strdup may silently fail without any message from tarantool. > Patch adds this checks. > --- > Branch: https://github.com/tarantool/tarantool/tree/OKriw/refactor-log-cfg > > v1: > https://www.freelists.org/post/tarantool-patches/PATCH-22-Added-strdup-fail-checks-in-say > > Changes in v2: > - no double check now > > src/say.c | 5 +++++ > 1 file changed, 5 insertions(+) This one looks good to me. > > diff --git a/src/say.c b/src/say.c > index 92e0e6d9f..99344b685 100644 > --- a/src/say.c > +++ b/src/say.c > @@ -502,6 +502,11 @@ log_syslog_init(struct log *log, const char *init_str) > log->syslog_ident = strdup("tarantool"); > else > log->syslog_ident = strdup(opts.identity); > + if (log->syslog_ident == NULL) { > + diag_set(OutOfMemory, strlen(opts.identity), "malloc", > + "log->syslog_ident"); > + return -1; > + } > > if (opts.facility == syslog_facility_MAX) > log->syslog_facility = SYSLOG_LOCAL7;