From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <vdavydov.dev@gmail.com>
Date: Thu, 19 Jul 2018 11:17:52 +0300
From: Vladimir Davydov <vdavydov.dev@gmail.com>
Subject: Re: [PATCH v3 03/11] Introduce IPROTO_REQUEST_STATUS command
Message-ID: <20180719081752.p2ddmow6dnf5725f@esperanza>
References: <cover.1531598427.git.vdavydov.dev@gmail.com>
 <b6e2fc55955a331b92cb1b81fec60818742473d3.1531598427.git.vdavydov.dev@gmail.com>
 <20180719071031.GC11373@chai>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20180719071031.GC11373@chai>
To: Konstantin Osipov <kostja@tarantool.org>
Cc: tarantool-patches@freelists.org
List-ID: <tarantool-patches.dev.tarantool.org>

On Thu, Jul 19, 2018 at 10:10:31AM +0300, Konstantin Osipov wrote:
> * Vladimir Davydov <vdavydov.dev@gmail.com> [18/07/14 23:50]:
> > The new command is supposed to supersede IPROTO_REQUEST_VOTE, which is
> > difficult to extend, because it uses the global iproto key namespace.
> > The new command returns a map (IPROTO_STATUS), to which we can add
> > various information without polluting the global namespace. Currently,
> > the map contains IPROTO_STATUS_IS_RO and IPROTO_STATUS_VCLOCK keys,
> > but soon it will be added info needed for replica rebootstrap feature.
> 
> Would it be possible to move out struct status from xrow.h and
> rename to box_status and move to box.h or some other place?

Then xrow.c would have to include box.h ...

> Perhaps we should remove it altogether, and simply pass multiple
> members to xrow_decode_status()?

There are already three members in a reply to a status request and may
be more in future. Passing them all in function arguments would look
cumbersome. We definitely need to group them somehow.

> 
> Other request member combos, such as authentication or call or eval have
> not leaked into xrow.h before. 

greeting, auth_request, call_request, request - they are all defined in
xrow.h