From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Date: Thu, 19 Jul 2018 10:10:31 +0300 From: Konstantin Osipov Subject: Re: [PATCH v3 03/11] Introduce IPROTO_REQUEST_STATUS command Message-ID: <20180719071031.GC11373@chai> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: To: Vladimir Davydov Cc: tarantool-patches@freelists.org List-ID: * Vladimir Davydov [18/07/14 23:50]: > The new command is supposed to supersede IPROTO_REQUEST_VOTE, which is > difficult to extend, because it uses the global iproto key namespace. > The new command returns a map (IPROTO_STATUS), to which we can add > various information without polluting the global namespace. Currently, > the map contains IPROTO_STATUS_IS_RO and IPROTO_STATUS_VCLOCK keys, > but soon it will be added info needed for replica rebootstrap feature. Would it be possible to move out struct status from xrow.h and rename to box_status and move to box.h or some other place? Perhaps we should remove it altogether, and simply pass multiple members to xrow_decode_status()? Other request member combos, such as authentication or call or eval have not leaked into xrow.h before. Otherwise the patch is OK to push. -- Konstantin Osipov, Moscow, Russia, +7 903 626 22 32 http://tarantool.io - www.twitter.com/kostja_osipov