From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <kostja@tarantool.org>
Date: Thu, 19 Jul 2018 10:08:22 +0300
From: Konstantin Osipov <kostja@tarantool.org>
Subject: Re: [PATCH v3 01/11] recovery: clean up WAL dir scan code
Message-ID: <20180719070822.GA11373@chai>
References: <cover.1531598427.git.vdavydov.dev@gmail.com>
 <24d2f80f4e3a2457abd9f9bbb95aab036e23a38b.1531598427.git.vdavydov.dev@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <24d2f80f4e3a2457abd9f9bbb95aab036e23a38b.1531598427.git.vdavydov.dev@gmail.com>
To: Vladimir Davydov <vdavydov.dev@gmail.com>
Cc: tarantool-patches@freelists.org
List-ID: <tarantool-patches.dev.tarantool.org>

* Vladimir Davydov <vdavydov.dev@gmail.com> [18/07/14 23:50]:
>  - Remove extra scan of the WAL directory from local_recovery() - we
>    scan the directory in recovery_end_vclock() hence we can skip scan in
>    recover_remaining_wals() by passing scan_dir = false.
> 
>  - Rename recovery_end_vclock() to recovery_scan() to emphasize the fact
>    that this function scans the WAL directory. Write a comment to this
>    function.
> 
>  - Add comments to wal.c explaining why we scan the WAL directory there.

Pushed.


-- 
Konstantin Osipov, Moscow, Russia, +7 903 626 22 32
http://tarantool.io - www.twitter.com/kostja_osipov