From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <vdavydov.dev@gmail.com>
Date: Tue, 17 Jul 2018 17:22:34 +0300
From: Vladimir Davydov <vdavydov.dev@gmail.com>
Subject: Re: [tarantool-patches] [PATCH 1/2] Test for valid syslog
 configuraton
Message-ID: <20180717142234.c4kqjsllcfynx7aq@esperanza>
References: <20180717102508.87945-1-arkholga@tarantool.org>
 <20180717131349.wgidrqo6xml4i7cb@esperanza>
 <1531836328.142893952@f406.i.mail.ru>
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <1531836328.142893952@f406.i.mail.ru>
To: Olga Arkhangelskaia <arkholga@tarantool.org>
Cc: tarantool-patches@freelists.org
List-ID: <tarantool-patches.dev.tarantool.org>

On Tue, Jul 17, 2018 at 05:05:28PM +0300, Olga Arkhangelskaia wrote:
> 
> 
> 
> >Вторник, 17 июля 2018, 16:13 +03:00 от Vladimir Davydov <vdavydov.dev@gmail.com>:
> >
> >As this is the second version of this patch, you should add v2 to the
> >subject line and write a brief change log. 
> Sorry, I remembered it after sending.
> >
> >
> >On Tue, Jul 17, 2018 at 01:25:07PM +0300, Olga Arkhangelskaia wrote:
> >> Added test to check if the valid syslog configuration is ok.
> >> 
> >> Issue: #3502
> >
> >Should be:
> >
> >Closes #3502 
> Is ir because it is a bug? Because Kirill told me about Issue: and Branch: and then links.

Forget about everything Kirill told you ;-) Just use patches submitted
by other team members as sample (you should be subscribed to the mailing
list so you can see all of them).

We mention an issue in the commit message so that it is recognized by
GitHub. E.g. 'Closes ####' will make GitHub close the issue once the
commit is pushed to the trunk.

We also include hyperlinks to the issue and branch in the patch email.
These are for the reviewer. They are not committed to the git.


BTW I see that you use Mail.Ru web interface. Please don't - it mangles
code snippets. I strongly recommend you to install a mail user agent,
e.g. Thuderbird.